-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn nightly tag generation into helper script that can run locally #5503
base: main
Are you sure you want to change the base?
Changes from all commits
60f3ff3
d530c9f
b8e29b7
141cbb0
68dac86
38d24f8
104d03b
f679a99
9572cb6
439557d
511ae3a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -163,10 +163,10 @@ https://github.com/KittyCAD/modeling-app/issues/new | |
|
||
#### 2. Push a new tag | ||
|
||
Create a new tag and push it to the repo. The `semantic-release.sh` script will automatically bump the minor part, which we use the most. For instance going from `v0.27.0` to `v0.28.0`. | ||
Create a new tag and push it to the repo. The `scripts/get-semantic-release-tag.sh` script will automatically bump the minor part, which we use the most. For instance going from `v0.27.0` to `v0.28.0`. | ||
|
||
``` | ||
VERSION=$(./scripts/semantic-release.sh) | ||
VERSION=$(./scripts/scripts/get-semantic-release-tag.sh) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updated name for consistency. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this line is wrong, it has double |
||
git tag $VERSION | ||
git push origin --tags | ||
``` | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it out of scope to get There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @franknoirot you know what let me break out the one line I care about today for the changelog fix. And let's have the ps1s for the og intent here! TYSM There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
#!/bin/bash | ||
VERSION_NO_V=$(date +'%-y.%-m.%-d') | ||
echo "nightly-v$VERSION_NO_V" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should fix the changelog by grabbing the prev prev tag.

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot the current line above doesn't work we have too many tag patterns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will be in #5550 actually