Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn nightly tag generation into helper script that can run locally #5503

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Turn nightly tag generation into helper script that can run locally #5503

wants to merge 11 commits into from

Conversation

pierremtb
Copy link
Collaborator

Fixes #5502

          TAG=$(./scripts/get-nightly-tag.sh)
          git tag $TAG
          git push origin tag $TAG

@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Feb 25, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel Vercel
Copy link

vercel bot commented Feb 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 27, 2025 2:27pm

@pierremtb pierremtb mentioned this pull request Feb 25, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Feb 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.41%. Comparing base (cb5ad3a) to head (511ae3a).
Report is 26 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5503      +/-   ##
==========================================
+ Coverage   86.29%   86.41%   +0.12%     
==========================================
  Files          95       97       +2     
  Lines       35941    37194    +1253     
==========================================
+ Hits        31014    32143    +1129     
- Misses       4927     5051     +124
Flag Coverage Δ
wasm-lib 86.41% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pierremtb and others added 9 commits February 25, 2025 16:22
@pierremtb
Getting the prev prev tag
d530c9f
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
b8e29b7 
…u-8-cores)
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
141cbb0 
…u-8-cores)
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
68dac86 
…u-8-cores)
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
38d24f8 
…u-8-cores)
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
104d03b 
…u-8-cores)
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
f679a99 
…u-8-cores)
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
9572cb6 
…u-8-cores)
@github-actions
A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-ubunt…
439557d 
…u-8-cores)
pierremtb
pierremtb commented Feb 26, 2025
View reviewed changes
.github/workflows/build-apps.yml
@@ -383,7 +383,7 @@ jobs:
# see https://github.com/actions/checkout/issues/1471
git fetch --prune --unshallow --tags
export TAG="nightly-${VERSION}"
export PREVIOUS_TAG=$(git describe --tags --match="nightly-v[0-9]*" --abbrev=0)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the changelog by grabbing the prev prev tag.
image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot the current line above doesn't work we have too many tag patterns

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be in #5550 actually

pierremtb
pierremtb commented Feb 26, 2025
View reviewed changes
README.md

```
VERSION=$(./scripts/semantic-release.sh)
VERSION=$(./scripts/scripts/get-semantic-release-tag.sh)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated name for consistency.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is wrong, it has double /scripts/scripts/, right?

@pierremtb pierremtb enabled auto-merge (squash) February 26, 2025 13:13
franknoirot
franknoirot requested changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the README edits just have a typo

README.md

```
VERSION=$(./scripts/semantic-release.sh)
VERSION=$(./scripts/scripts/get-semantic-release-tag.sh)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is wrong, it has double /scripts/scripts/, right?

scripts/get-nightly-tag.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it out of scope to get .ps1 versions of these scripts and add them to package.json as named Yarn commands? I don't mind if that's another PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franknoirot you know what let me break out the one line I care about today for the changelog fix. And let's have the ps1s for the og intent here! TYSM

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#5550

@pierremtb pierremtb mentioned this pull request Feb 27, 2025
Merged
@pierremtb pierremtb marked this pull request as draft February 27, 2025 14:38
auto-merge was automatically disabled February 27, 2025 14:38

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franknoirot franknoirot franknoirot requested changes

@nadr0 nadr0 Awaiting requested review from nadr0

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn nightly tag generation into helper script that can run locally
2 participants
@pierremtb @franknoirot