Fix switching between KCL arguments #5512
Merged
+20
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed to imperatively send a transaction to the editor, since it doesn't get re-rendered when switching from one KCL-type arg to another.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5512 +/- ##
=======================================
Coverage 86.41% 86.42%
=======================================
Files 97 97
Lines 37194 37194
=======================================
+ Hits 32143 32144 +1
+ Misses 5051 5050 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks fantastic! |
Irev-Dev
approved these changes
Feb 27, 2025
|
Thanks @pierremtb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5484. Just needed to imperatively send a transaction to the editor, since it doesn't get re-rendered when switching from one KCL-type arg to another.
Completely developed while using ✨Windows✨
Demo
Screenshare.-.2025-02-25.6_12_51.PM-compressed.mp4