Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.thrift: Fix python 3.12 support #328246

Closed
wants to merge 2 commits into from

Conversation

kfollesdal
Copy link
Contributor

Description of changes

This give python package thrift python 3.12 support.

Is a better and simpler solutions than first attempt that modify setuptools: #328182

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wegank
Copy link
Member

wegank commented Jul 18, 2024

Just leaving a comment to keep me in the loop, as this PR and #326321 are essentially targeting the same issue.

@dotlambda
Copy link
Member

dotlambda commented Jul 19, 2024

What about using a distutils package from PyPI on Python 3.12? #328379

@kfollesdal
Copy link
Contributor Author

We can also consider to fix setuptools to behave as expected by adding the following lines to setuptools:

postInstall = ''
  ln -s $out/${python.sitePackages}/setuptools/_distutils  $out/${python.sitePackages}/distutils
 '';

But will give mass rebuild, but solve build problems for other python packages and avoid problems/confusion.

Will make a PR, that can be evaluated.

@kfollesdal
Copy link
Contributor Author

See #328415 for proposal to fix setuptools to behave as expected.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@ghost ghost closed this Dec 19, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants