-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.distutils: init at 0.70.0 #328379
python312Packages.distutils: init at 0.70.0 #328379
Conversation
Would this same issue also be solved by fixing the issue that causes |
}: | ||
|
||
buildPythonPackage rec { | ||
pname = "standard-distutils"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be more comfortable to use a more official source https://github.com/pypa/distutils, that is the source for the distutils
that setuptools
offer.
Yes.
Same. But that's a mass rebuild. |
What if we add a |
5f439c6
to
e7f2aa5
Compare
It seemed easier to use https://github.com/pypa/distutils because it comes with |
I have made a proposal to fix |
e7f2aa5
to
431c24c
Compare
I'm now pulling the code, except for tests, build files, etc., from our setuptools package. So compatibility should be guaranteed. |
Take the actual code from setuptools for compatibility.
431c24c
to
efa00bf
Compare
e74cac4
to
3dbc32f
Compare
I'll merge this now cause the other option needs a whole staging cycle. If we agree the other solution is better we can revert this on staging. |
Description of changes
fixes #328346
fixes #326296
closes #326321
fixes #326920
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.