fix: Safely add livestream host #28727
Merged
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +32 B (0%) Total Size: 9.72 MB ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds proper livestream host configuration across the PostHog stack, focusing on safe and consistent host resolution.
- Added new
LIVESTREAM_HOSTenvironment variable in/posthog/settings/web.pyfor configuring the livestream connection endpoint - Modified
/frontend/src/lib/utils/apiHost.tsto use app context for livestream host resolution with proper fallbacks for different environments - Added
livestream_hostto frontend app context in/posthog/utils.pyto expose the configuration to client-side - Extended AppContext interface in
/frontend/src/types.tswith optionallivestream_hostproperty
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
pauldambra
approved these changes
Feb 25, 2025
pauldambra
reviewed
Feb 25, 2025
| @@ -126,6 +126,7 @@ $TLS_BLOCK | |||
| $DOMAIN, http://, https:// { | |||
| encode gzip zstd | |||
| reverse_proxy http://web:8000 | |||
| reverse_proxy http://livestream:8666 | |||
There was a problem hiding this comment.
aaaaahhhhhhh, dang of course
thmsobrmlr
pushed a commit
that referenced
this pull request
Feb 25, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Paul D'Ambra <[email protected]> Co-authored-by: James Greenhill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Re-adds the livestream host in a way that doesn't break things....
How did you test this code?
locally this runs and livestream works
in self-hosted if i manually add the livestream service then I can see livestream start and try to connect to the incorrect host (because it doesn't have this change)