-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devex): cypress roulette #29181
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR modifies the Cypress E2E testing strategy to run only 4 randomly selected tests per CI run instead of all tests.
- Added a new step in the
chunks
job that selects 4 random spec files using the commit's SHA as a seeded random source - Changed matrix variable from
chunk
tospec
throughout the workflow for clarity - Updated artifact naming to use the specific spec name instead of job index
- Modified the Cypress run command to execute only the selected spec files
- Implemented a reproducible selection mechanism using the commit SHA to ensure consistent test selection for the same code
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
@@ -58,32 +58,36 @@ jobs: | |||
- name: Check out | |||
uses: actions/checkout@v3 | |||
|
|||
- name: Group spec files into chunks of three | |||
- name: Pick 4 random spec files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think once a day we should run them all and send an event to posthog on failure so we can alert from CDP / track incidence
but otherwise 100
these tests are slow and low value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that works for me. Though the only thing these tests actually test for me is that the plugin server is running. I didn't (yet) explicitly verify if the same issue causes playwright to break as well... will report back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, they're a bit of a dead end cos everyone just finds them annoying...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, we'd make them not required and tell everyone, plz be careful-er now
any migration to playwright that is done carefully will just take too long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm in
Problem
We spend too much on cypress with not much to show.
Changes
Run only 4 random cypress tests each run.
How did you test this code?
See the above 🤪