-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devex): cypress roulette #29181
Open
mariusandra
wants to merge
15
commits into
master
Choose a base branch
from
cypress-roulette
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−29
Open
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
de13320
feat(devex): cypress roulette
mariusandra ce8404b
fix
mariusandra bb6ad5e
run tests
mariusandra 70f2e86
throw money at the problem
mariusandra 0ea9cd7
bacon
mariusandra 530aa9b
shalala
mariusandra abca481
moar
pauldambra fd3df6f
Merge branch 'master' into cypress-roulette
pauldambra fe06ec6
Merge branch 'cypress-roulette' of github.com:PostHog/posthog into cy…
mariusandra fed023b
Merge remote-tracking branch 'origin' into cypress-roulette
mariusandra f881b9d
try this
mariusandra 95bc5db
ci
mariusandra f60b0e3
remove scripts we do not need
mariusandra 996b032
dunno
mariusandra 820c9a9
revert a bunch of stuff
mariusandra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think once a day we should run them all and send an event to posthog on failure so we can alert from CDP / track incidence
but otherwise 100
these tests are slow and low value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that works for me. Though the only thing these tests actually test for me is that the plugin server is running. I didn't (yet) explicitly verify if the same issue causes playwright to break as well... will report back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For clarity I put the name of the test into the action's name, but this just means none will actually be required:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, they're a bit of a dead end cos everyone just finds them annoying...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, we'd make them not required and tell everyone, plz be careful-er now
any migration to playwright that is done carefully will just take too long