revert: "chore(batch-exports): Revert "chore: upgrade minio"" #29189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 75274e5.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR re-upgrades the MinIO object storage service from a 2022 version to a 2025 version, reverting a previous reversion that was made due to failing tests.
- Updated MinIO image in
docker-compose.base.ymlfrom RELEASE.2022-06-25T15-50-16Z to RELEASE.2025-02-18T16-25-55Z - The upgrade is targeted at self-hosted environments only, as MinIO is not used in production
- The PR aims to fix the test failures that caused the original upgrade to be reverted
- The change is isolated to the
objectstorageservice configuration in the Docker Compose file
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
pauldambra
commented
Feb 25, 2025
posthog/temporal/tests/batch_exports/test_s3_batch_export_workflow.py
Outdated
Show resolved
Hide resolved
pauldambra
commented
Feb 25, 2025
| @@ -122,7 +122,7 @@ services: | |||
| DYNAMIC_CONFIG_ENABLED: 'true' | |||
|
|
|||
| objectstorage: | |||
| image: minio/minio:RELEASE.2022-06-25T15-50-16Z | |||
| image: minio/minio:RELEASE.2025-02-18T16-25-55Z | |||
There was a problem hiding this comment.
this is the version I've validated works for local dev and for self hosted
pauldambra
commented
Feb 25, 2025
| @@ -168,7 +168,7 @@ async def minio_client(bucket_name): | |||
|
|
|||
| yield minio_client | |||
|
|
|||
| await delete_all_from_s3(minio_client, bucket_name, key_prefix="/") | |||
| await delete_all_from_s3(minio_client, bucket_name, key_prefix="") | |||
There was a problem hiding this comment.
the prefix / was leaving one file behind that was at the root of the bucket...
so I made it the empty string instead 🤷
i'm guessing we don't care @Gilbert09 @rossgray
There was a problem hiding this comment.
Not sure why that behaviour has changed then but sounds like it should be fine
Gilbert09
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #29188
which was a revert of #29166
We still need to upgrade this for self-hosted but need to get tests running in this PR so we can see if it's only incidental that they're failing
We don't use minio in production, so should be totally safe
you can see the failing tests here https://github.com/PostHog/posthog/actions/runs/13521771267/job/37782507932?pr=29136