Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "chore(batch-exports): Revert "chore: upgrade minio"" #29189

Merged
merged 6 commits into from
Feb 25, 2025
Merged

revert: "chore(batch-exports): Revert "chore: upgrade minio"" #29189

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7899b98
Revert "chore(batch-exports): Revert "chore: upgrade minio" (#29188)"
pauldambra Feb 25, 2025
b199e6f
change something to make the tests run
pauldambra Feb 25, 2025
28fbe2c
more deleting then before
pauldambra Feb 25, 2025
ad05b7d
Update posthog/temporal/tests/batch_exports/test_s3_batch_export_work…
pauldambra Feb 25, 2025
5667720
more
pauldambra Feb 25, 2025
3fa7630
Merge branch 'master' into revert-29188-revert-29166-chore/upgrade-minio
pauldambra Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose.base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ services:
DYNAMIC_CONFIG_ENABLED: 'true'

objectstorage:
image: minio/minio:RELEASE.2022-06-25T15-50-16Z
image: minio/minio:RELEASE.2025-02-18T16-25-55Z
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the version I've validated works for local dev and for self hosted

restart: on-failure
environment:
MINIO_ROOT_USER: object_storage_root_user
Expand Down
2 changes: 1 addition & 1 deletion posthog/temporal/tests/batch_exports/test_s3_batch_export_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ async def minio_client(bucket_name):

yield minio_client

await delete_all_from_s3(minio_client, bucket_name, key_prefix="/")
await delete_all_from_s3(minio_client, bucket_name, key_prefix="")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the prefix / was leaving one file behind that was at the root of the bucket...
so I made it the empty string instead 🤷

i'm guessing we don't care @Gilbert09 @rossgray

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it works 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why that behaviour has changed then but sounds like it should be fine


await minio_client.delete_bucket(Bucket=bucket_name)

Expand Down
2 changes: 1 addition & 1 deletion posthog/temporal/tests/external_data/test_external_data_job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def minio_client(bucket_name):

yield minio_client

delete_all_from_s3(minio_client, bucket_name, key_prefix="/")
delete_all_from_s3(minio_client, bucket_name, key_prefix="")

minio_client.delete_bucket(Bucket=bucket_name)

Expand Down
Loading