feat(data-warehouse): New snowflake source #29317
Merged
+161
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds a new Snowflake data source to PostHog's data warehouse functionality, leveraging the snowflake-connector-python package for simplified data retrieval.
- Added
posthog/temporal/data_imports/pipelines/snowflake/snowflake.pywith support for both password and key-based authentication - Updated snowflake-connector-python from version 3.6.0 to 3.13.2 in requirements files
- Implemented PyArrow-based data retrieval for efficient schema/type handling without manual mapping
- Modified
import_data_sync.pyto use the dedicated snowflake module instead of generic sql_database - Removed unused
team_idparameter from mysql_source function for code cleanup
6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
phixMe
reviewed
Feb 28, 2025
Comment on lines
+17
to
+20
| user: Optional[str], | ||
| password: Optional[str], | ||
| passphrase: Optional[str], | ||
| private_key: Optional[str], |
There was a problem hiding this comment.
I think you could possibly handle the optionals earlier in the other function, to avoid optional parameter passing through 2 functions the chain here, but not a huge deal either way.
phixMe
approved these changes
Feb 28, 2025
Gilbert09
added a commit
that referenced
this pull request
Feb 28, 2025
This reverts commit 8fef3f6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
snowflake-connector-pythonpackage, supported by snowflake!Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Yep, tested a bunch locally