perf: Change link-time optimization in dev and test #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljedrz
reviewed
Nov 19, 2024
Raphexion
force-pushed
the
nijo/speed-up-dev-test-cycle
branch
from
0c33479 to
a1918e1
Compare
Raphexion
force-pushed
the
nijo/speed-up-dev-test-cycle
branch
from
a1918e1 to
6a5a31b
Compare
|
Now that CI works again, do you mind rebasing on the latest |
Raphexion
force-pushed
the
nijo/speed-up-dev-test-cycle
branch
from
6a5a31b to
34b0f1b
Compare
|
@vicsn Thanks for helping with this PR. I've created a similar PR for SnarkVM as you suggested: |
|
Seems like the snarkOS CircleCI tests do run slower, 23 minutes on this PR instead of 17 or 18 minutes on recent PRs. Can you remove the link-time optimization for the test profile? We can keep it as the default on the dev profile. :) Also the |
This change improves the development cycle in both dev and test, when running the same command multiple times in a row. On my machine I can see improvements from minutes to seconds. For example when running `cargo run` and `cargo test`. Co-authored-by: Paul Dann <[email protected]>
Raphexion
force-pushed
the
nijo/speed-up-dev-test-cycle
branch
from
34b0f1b to
b76bb9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change improves the development cycle in both dev and test, when running the same command multiple times in a row.
On my machine I can see improvements from minutes to seconds. For example when running
cargo runandcargo test.Test Plan
Compare running this commands 3 times in a row with or without this patch
Related PRs
None