perf: Change link-time optimization in dev and test #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"This branch is out-of-date with the base branch" |
This change improves the development cycle in both dev and test, when running the same command multiple times in a row. On my machine I can see improvements from minutes to seconds. For example when running `cargo run` and `cargo test`. Co-authored-by: Paul Dann <[email protected]>
Raphexion
force-pushed
the
nijo/speed-up-dev-test-cycle
branch
from
6117881 to
379062c
Compare
|
Regarding Lukasz' comment. Seems like the snarkVM CircleCI tests do run slower, 30 minutes on this PR instead of 20 or 22 minutes on recent PRs. This difference will matter a lot when we need to push a hotfix through. Can you remove the link-time optimization for the test profile? We can keep it as the default on the dev profile. :) Also from this and a couple other PRs it seems that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change improves the development cycle in both dev and test, when running the same command multiple times in a row.
On my machine I can see improvements from minutes to seconds. For example when running
cargo runandcargo test.Test Plan
Compare running a commands 3 times in a row with or without this patch.
Related PRs
None