You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @annavik! This started as a "simple" change so users can make and populate Collections in the UI, since that is a missing piece for the batch processing workflow. But it turned out to be my largest contribution to the UI code yet! And I had a lot of catching up to do. I know this could be cleaner, but I am hoping to compromise and make something available to demo soon. We should probably discuss more about collections. They may be outgrowing the sub-tab under project overview.
After this, I am definitely look forward to re-using the backend types in the frontend. I tested that using our autogenerated openAPI schema -> typscript and it worked amazingly well. I will make a PR with an example soon. Also I am curious about using react-hook-form library more directly. It seems like there are some layers of abstraction/simplification that could be skipped? It was difficult for me to find where values are being transformed before being passed to the server. Anyway, take a look if you have a chance, but no worries if we have to wait until June.
mihow
changed the title
AMI-267-Enable-Collections-to-be-defined-populated-from-UI
[AMI-267] Enable collections to be defined & populated from UI
Apr 17, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mihow
changed the title
Description TBD!