Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Timeout option from WaitFor* methods #291

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

kangasta
Copy link
Contributor

@kangasta kangasta commented Jan 25, 2024

This is to remove duplicate timeouts: the context.Context parameter passed in to the WaitFor* methods might already have an timeout defined. Thus, the Timeout field might cause confusing errors when, for example, the timeout defined in Timeout field is shorter than timeout defined in the context passed in from e.g. Terraform.

@kangasta kangasta force-pushed the refactor/wait-for-timeout branch 2 times, most recently from 138d9f1 to 4773fb2 Compare January 26, 2024 11:07
@kangasta kangasta marked this pull request as ready for review January 26, 2024 11:29
@kangasta kangasta requested a review from a team as a code owner January 26, 2024 11:29
@kangasta kangasta force-pushed the refactor/wait-for-timeout branch from 4773fb2 to a237887 Compare January 26, 2024 11:30
@kangasta kangasta merged commit 6d789dd into main Jan 26, 2024
6 checks passed
@kangasta kangasta deleted the refactor/wait-for-timeout branch January 26, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants