Code

Improve "perimeter" classification#94

Code

Merged

dabreegster merged 22 commits intoa-b-street:maina-b-street/ltn:mainfrom michaelkirk:mkirk/improve-roads-in-boundarymichaelkirk/ltn:mkirk/improve-roads-in-boundaryCopy head branch name to clipboardJan 23, 2025

+902-110

Commits

Commits on Jan 22, 2025

• Baseline benchmarks for neighbourhood building.

  Show description for 4664a09
  michaelkirk

  committed
  4664a09

  Copy full SHA for 4664a09

• unnecessary clone

  michaelkirk

  committed
  27c86ca

  Copy full SHA for 27c86ca

• test existing behavior

  michaelkirk

  committed
  0b1c9a5

  Copy full SHA for 0b1c9a5

• streets mostly contained in the neighborhood are interior

  Show description for 6eb98c4
  michaelkirk

  committed
  6eb98c4

  Copy full SHA for 6eb98c4

• Use frechet distance/snapping to detect perimeter.

  Show description for 0fb367d
  michaelkirk

  committed
  0fb367d

  Copy full SHA for 0fb367d

• PERF: reverse linestring rather than polygon

  michaelkirk

  committed
  a528f19

  Copy full SHA for a528f19

• PERF: compute two halves of boundary in one pass

  Show description for 67cfaf8
  michaelkirk

  committed
  67cfaf8

  Copy full SHA for 67cfaf8

• PERF: try using buffered boundary to preclude more efficiently

  Show description for 8969d62
  michaelkirk

  committed
  8969d62

  Copy full SHA for 8969d62

• Revert "try using buffered boundary to preclude more efficiently"

  Show description for 551c280
  michaelkirk

  committed
  551c280

  Copy full SHA for 551c280

• Fix segments near invalid spikes expluded from perimeter

  Show description for a239f5c
  michaelkirk

  committed
  a239f5c

  Copy full SHA for a239f5c

• WIP: fix classification of Crossing

  Show description for dbc999a
  michaelkirk

  committed
  dbc999a

  Copy full SHA for dbc999a

• Revert "WIP: fix classification of Crossing"

  Show description for 49d2b8f
  michaelkirk

  committed
  49d2b8f

  Copy full SHA for 49d2b8f

• Consider Crossing roads Perimeter if they cross more than a trivial amount.

  Show description for d37d2c1
  michaelkirk

  committed
  d37d2c1

  Copy full SHA for d37d2c1

• minimize diff, add comments

  michaelkirk

  committed
  7527779

  Copy full SHA for 7527779

• no need to reverse line

  michaelkirk

  committed
  98bdaa9

  Copy full SHA for 98bdaa9

• use dependency from github

  michaelkirk

  committed
  6df939f

  Copy full SHA for 6df939f

• respond to code review

  Show description for 5f918a9
  michaelkirk

  committed
  5f918a9

  Copy full SHA for 5f918a9

• remove old references to "crosses" layer

  michaelkirk

  committed
  c18971f

  Copy full SHA for c18971f

• extract make_polygon_valid function and document better

  michaelkirk

  committed
  be5dd9a

  Copy full SHA for be5dd9a

• document wkt usage

  michaelkirk

  committed
  dc36bf7

  Copy full SHA for dc36bf7

• update comment per review

  michaelkirk

  committed
  f346907

  Copy full SHA for f346907

• fix typo

  michaelkirk

  committed
  334f94c

  Copy full SHA for 334f94c