Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "perimeter" classification #94

Merged
merged 22 commits into from
Jan 23, 2025
Merged

Improve "perimeter" classification #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
4664a09
Baseline benchmarks for neighbourhood building.
michaelkirk Jan 17, 2025
27c86ca
unnecessary clone
michaelkirk Jan 14, 2025
0b1c9a5
test existing behavior
michaelkirk Jan 14, 2025
6eb98c4
streets mostly contained in the neighborhood are interior
michaelkirk Jan 15, 2025
0fb367d
Use frechet distance/snapping to detect perimeter.
michaelkirk Jan 16, 2025
a528f19
PERF: reverse linestring rather than polygon
michaelkirk Jan 21, 2025
67cfaf8
PERF: compute two halves of boundary in one pass
michaelkirk Jan 21, 2025
8969d62
PERF: try using buffered boundary to preclude more efficiently
michaelkirk Jan 18, 2025
551c280
Revert "try using buffered boundary to preclude more efficiently"
michaelkirk Jan 21, 2025
a239f5c
Fix segments near invalid spikes expluded from perimeter
michaelkirk Jan 21, 2025
dbc999a
WIP: fix classification of Crossing
michaelkirk Jan 21, 2025
49d2b8f
Revert "WIP: fix classification of Crossing"
michaelkirk Jan 21, 2025
d37d2c1
Consider Crossing roads Perimeter if they cross more than a trivial a…
michaelkirk Jan 21, 2025
7527779
minimize diff, add comments
michaelkirk Jan 21, 2025
98bdaa9
no need to reverse line
michaelkirk Jan 22, 2025
6df939f
use dependency from github
michaelkirk Jan 22, 2025
5f918a9
respond to code review
michaelkirk Jan 22, 2025
c18971f
remove old references to "crosses" layer
michaelkirk Jan 22, 2025
be5dd9a
extract make_polygon_valid function and document better
michaelkirk Jan 22, 2025
dc36bf7
document wkt usage
michaelkirk Jan 22, 2025
f346907
update comment per review
michaelkirk Jan 22, 2025
334f94c
fix typo
michaelkirk Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
228 changes: 225 additions & 3 deletions backend/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 10 additions & 2 deletions backend/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,21 @@ web-sys = { version = "0.3.64", features = ["console"] }
web-time = "1.0.0"
petgraph = "0.7.1"

[dev-dependencies]
criterion = "0.5.1"
approx = "0.5.1"

# For local development, build dependencies in release mode once, but otherwise
# use dev profile and avoid wasm-opt.
[profile.dev.package."*"]
opt-level = 3

[[bench]]
name = "build_neighbourhood"
harness = false

[patch.crates-io]
# use unreleased `geo` and `geo-types` to fix crash: https://github.com/a-b-street/ltn/issues/54
# (awaiting release of https://github.com/georust/geo/pull/1279)
geo = { version = "0.29.1", git = "https://github.com/georust/geo", branch = "release/geo-types-v0.7.15" }
geo-types = { version = "0.7.15", git = "https://github.com/georust/geo", branch = "release/geo-types-v0.7.15" }
geo = { git = "https://github.com/georust/geo" }
geo-types = { git = "https://github.com/georust/geo" }
Loading