-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-36832] Remove Deprecated classes and relevant tests. #139
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) |
Hi, @PatrickRen @AHeise. Could you please help to review this? |
Hi @lvyanquan , thank you very much for tackling the release. Unfortunately, I don't have time to review it this year and per prior agreement, I expected @PatrickRen and @leonardBang to pick this up. I will ping them again on slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lvyanquan for the PR, I left one comment
import java.util.UUID; | ||
|
||
/** IT cases for Kafka. */ | ||
public class KafkaITCase extends KafkaConsumerTestBase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have new test/ITCase which bases on new API that covers these cases ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have independent test for new Source/SInk API in KafkaSinkITCase and KafkaSourceITCase, but I don't see they are equivalent to the previous testing scenarios, these new tests are designed separately.
Remove Deprecated classes and relevant tests, and annotated some classes from Deprecated to Internal.