Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Copy for Enrollment Start, Enrollment Success, Help, 404, 500 #725

Merged
merged 11 commits into from
Jun 23, 2022

Conversation

machikoyasuda
Copy link
Member

@machikoyasuda machikoyasuda commented Jun 22, 2022

closes #676

This PR updates several pages of copy for both English and Spanish:

  • Spanish: Elig Start
  • Spanish: Enrollment Success
  • Spanish: Help
  • Eng & Sp: 404
  • Eng & Sp: 500
  • Eng & Sp: Elig Error

@github-actions github-actions bot added deployment-dev [auto] Changes that will trigger a deploy if merged to dev i18n Copy: Language files or Django i18n framework and removed deployment-dev [auto] Changes that will trigger a deploy if merged to dev labels Jun 22, 2022
@machikoyasuda machikoyasuda changed the title Spanish copy for Enrollment Start, Enrollment Success, Help New Copy for Enrollment Start, Enrollment Success, Help, 404, 500 Jun 22, 2022
@machikoyasuda machikoyasuda marked this pull request as ready for review June 22, 2022 23:57
@machikoyasuda machikoyasuda requested a review from a team as a code owner June 22, 2022 23:57
@thekaveman
Copy link
Member

Looking at this 👀

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few minor comments inline.

I think the Enrollment index page is missing some updates (both English and Spanish), link to section is GDoc

English:

# Let’s link your card to your discount.

Now that you are logged in we can link your transit discount to your card through our payment partner, LittlePay.

We don’t store your information, and you won’t be charged. When you use this card to pay for transit, you will always receive your discount.

Please use a bank-issued contactless Visa or Mastercard credit or debit card.

Spanish:

# Vamos a vincular su tarjeta con su descuento.

Ahora que ha iniciado sesión, podemos vincular su descuento de tránsito a su tarjeta a través de nuestro socio de pagos, Littlepay.

No almacenamos su información y no se le cobrará. Cuando utilice esta tarjeta para pagar el tránsito, siempre recibirá su descuento.

Utilice una tarjeta de crédito o débito Visa o Mastercard sin contacto emitida por un banco.

benefits/locale/es/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
benefits/locale/es/LC_MESSAGES/django.po Outdated Show resolved Hide resolved
@machikoyasuda
Copy link
Member Author

Screenshots - Could not be verified page

image

image

@machikoyasuda
Copy link
Member Author

@thekaveman Ready for re-review

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! 🎸

@machikoyasuda machikoyasuda merged commit 6961c73 into dev Jun 23, 2022
@machikoyasuda machikoyasuda deleted the feat/copy branch June 23, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Copy: Language files or Django i18n framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Engineering: Load Spanish Translations for new copy
2 participants