Make some resource PDFs a11y friendly #402
Conversation
✅ Deploy Preview for cal-itp-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| asset: "Cal-ITP.Transit.Draft.Guidelines.Draft.3.Feedback.pdf" | ||
| asset: "Cal-ITP.Transit.Draft.Guidelines.Feedback.pdf" |
There was a problem hiding this comment.
@mrose914 is this change okay? The updated file you gave me had the updated name without the extra Draft.3 so I kept that name. Just to let you know, if this PDF has been linked to by another site or page, this name change could break those links.
There was a problem hiding this comment.
I checked on Google Search Console and other backlinks checkers to see if there are any websites that link to https://www.calitp.org/assets/Cal-ITP.Transit.Draft.Guidelines.Draft.3.Feedback.pdf. Then, I checked in the Cal-ITP Slack to see if this URL is linked or referenced there -- no references. So I feel comfortable changing this link.
In an ideal future scenarios, we should reject URL filenames with Draft in them.
There was a problem hiding this comment.
Wait @machikoyasuda @allejo I think this was incorrect, or at least wasn't finished all the way.
This links to a deck on Cal-ITP's work on the Draft v3 Transit Data Guidelines (e.g. the working version of v3 when it was in-progress but v2 was still current). This deck is highlighting feedback Cal-ITP took during the development of this v3 update.
In any case, Draft is still in the file name (in a place that makes even less sense than the one that was deleted), but now we lost the 3 version number.
There was a problem hiding this comment.
Ooooh... oops. It looks like we are waiting on GDrive access to this PDF still?
There was a problem hiding this comment.
Wait. No. I see we do have the PDF here now: https://github.com/cal-itp/calitp.org/blob/6c97915c3d49326746d0bf04e2d77a60c967e0ca/src/assets/Cal-ITP.Transit.Draft.Guidelines.Feedback.pdf
I see the PDF itself has the title: CA Transit Data Guidlines Draft v3.0 Feedback, so it seems to me like that would be the best URL slug?
There was a problem hiding this comment.
Will make a new issue and PR to fix
|
Sorry @allejo, I didn't realize @machikoyasuda wasn't part of the @machikoyasuda I added you to that team now. This team was originally set up so @mrose914 could approve simple content changes for go-live without an engineer. |
|
Sorry to jump in late here - I think I changed the file settings so they are accessible to all. Lmk if you need my review on anything |
|
Update: All fixed in this PR #405 - Thanks @mrose914 @allejo @thekaveman |
Closes #399