-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make some resource PDFs a11y friendly #402
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
src/_resources/slide-deck-ca-transit-data-guidelines-draft-v3.0.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file renamed
BIN
+499 KB
...sit.Draft.Guidelines.Draft.3.Feedback.pdf → ...ITP.Transit.Draft.Guidelines.Feedback.pdf
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrose914 is this change okay? The updated file you gave me had the updated name without the extra
Draft.3so I kept that name. Just to let you know, if this PDF has been linked to by another site or page, this name change could break those links.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked on Google Search Console and other backlinks checkers to see if there are any websites that link to https://www.calitp.org/assets/Cal-ITP.Transit.Draft.Guidelines.Draft.3.Feedback.pdf. Then, I checked in the Cal-ITP Slack to see if this URL is linked or referenced there -- no references. So I feel comfortable changing this link.
In an ideal future scenarios, we should reject URL filenames with Draft in them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait @machikoyasuda @allejo I think this was incorrect, or at least wasn't finished all the way.
This links to a deck on Cal-ITP's work on the Draft v3 Transit Data Guidelines (e.g. the working version of v3 when it was in-progress but v2 was still current). This deck is highlighting feedback Cal-ITP took during the development of this v3 update.
In any case,
Draftis still in the file name (in a place that makes even less sense than the one that was deleted), but now we lost the3version number.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooooh... oops. It looks like we are waiting on GDrive access to this PDF still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait. No. I see we do have the PDF here now: https://github.com/cal-itp/calitp.org/blob/6c97915c3d49326746d0bf04e2d77a60c967e0ca/src/assets/Cal-ITP.Transit.Draft.Guidelines.Feedback.pdf
I see the PDF itself has the title: CA Transit Data Guidlines Draft v3.0 Feedback, so it seems to me like that would be the best URL slug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will make a new issue and PR to fix