Feature/ws2 2949 locking add graphql support #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulLeCam
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Looks great for the devtools part, but could you also update the runtime schema so that immutable fields are not present in the update inputs please?
The method generating these inputs is here: https://github.com/ceramicstudio/js-composedb/blob/main/packages/runtime/src/schema.ts#L866
I think that will also require some changes to the runtime definition to indicate what fields are immutable, here are the shared type definitions: https://github.com/ceramicstudio/js-composedb/blob/main/packages/types/src/index.ts
Let me know if you need more details or you want to sync on these changes some time!
PaulLeCam
reviewed
Jan 25, 2024
PaulLeCam
reviewed
Jan 26, 2024
JulissaDantes
force-pushed
the
feature/ws2-2949-locking-add-graphql-support
branch
from
655b51c to
ff1588d
Compare
PaulLeCam
suggested changes
Feb 9, 2024
Co-authored-by: Paul Le Cam <[email protected]>
Co-authored-by: Paul Le Cam <[email protected]>
JulissaDantes
deleted the
feature/ws2-2949-locking-add-graphql-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to wait for the Ceramic side to be ready, but we could start reviewing this side in the meantime. Here we add the new directive to recognize immutable fields and make sure to support parsing it.