fix: recognize immutable fields in lists #227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
stbrody
reviewed
Jul 24, 2024
stbrody
reviewed
Jul 24, 2024
PaulLeCam
suggested changes
Jul 25, 2024
| expect(res2.errors![0].message).toEqual( | ||
| `Variable "$i" got invalid value { title: "A different title" } at "i.content"; Field "title" is not defined by type "PartialPostInput". Did you mean "date"?`, | ||
| ) | ||
| expect(res2.errors![1].message).toContain( |
There was a problem hiding this comment.
I don't really like the idea of testing the immutable fields handling based on parsing GraphQL queries, this seems pretty fragile.
I think instead there should be a direct call to the Ceramic server trying to make an update to an immutable field and getting the matching error message, what do you think?
There was a problem hiding this comment.
Agreed. FYI I'll close this PR, rebasing from main didnt helped, but I created a new branch branch with the changes(missing this last change) and I'll ask for a review on the new one that doesnt seem to have the CI issue
|
Marking as draft until I fix the CI |
|
Ci fixed here: #228 |
JulissaDantes
force-pushed
the
fix/immutable-lists
branch
from
025bec0 to
fd65109
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current version a field declared as
uniqueListValue: [Int] @list(maxLength: 5) @immutableis not included in the ImmutableFields. This PR allows to identify these kinds of declarations.