Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update _parseListType #229

Merged
merged 2 commits into from
Jul 26, 2024
Merged

feat: update _parseListType #229

merged 2 commits into from
Jul 26, 2024

Conversation

JulissaDantes
Copy link
Contributor

@JulissaDantes JulissaDantes commented Jul 26, 2024

Description
In the current version a field declared as uniqueListValue: [Int] @list(maxLength: 5) @immutable is not included in the ImmutableFields. This PR allows to identify these kinds of declarations.

This is the working CI version of #227

@JulissaDantes JulissaDantes requested a review from PaulLeCam July 26, 2024 14:42
@JulissaDantes JulissaDantes marked this pull request as ready for review July 26, 2024 14:42
PaulLeCam
PaulLeCam previously approved these changes Jul 26, 2024
Copy link
Contributor

@PaulLeCam PaulLeCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

packages/devtools/src/schema/parser.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@PaulLeCam PaulLeCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@JulissaDantes JulissaDantes merged commit 941a947 into main Jul 26, 2024
5 checks passed
@JulissaDantes JulissaDantes deleted the fix/immutable-lists-2 branch July 26, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants