Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: generate job matrix through a Python script #198

Merged
merged 3 commits into from
Oct 20, 2021

Conversation

umarcor
Copy link
Contributor

@umarcor umarcor commented Oct 19, 2021

@umarcor umarcor force-pushed the ci/matrix branch 2 times, most recently from 46e3ed9 to 978d258 Compare October 19, 2021 22:03
@umarcor umarcor force-pushed the ci/matrix branch 3 times, most recently from c479528 to ef19a08 Compare October 19, 2021 22:07
@umarcor
Copy link
Contributor Author

umarcor commented Oct 20, 2021

@mithro it seems that the only failing job is because of a communication issue. I believe this can be merged.

@kgugala
Copy link
Member

kgugala commented Oct 20, 2021

LGTM

@kgugala kgugala merged commit 848291d into chipsalliance:master Oct 20, 2021
@umarcor umarcor deleted the ci/matrix branch October 20, 2021 12:41
@@ -0,0 +1,42 @@
#!/usr/bin/env python3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should have had a copyright header.

@kgugala / @acomodi -- Any idea why CI didn't detect this?

Copy link
Contributor Author

@umarcor umarcor Oct 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #202 and #200.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI was just running tuttest on the README.. It was never checking the headers. The original purpose was to have a few examples to show how to use the toolchain in Debian, not a huge vehicle to test everything on every possible Linux distro ;) Then it grew but nobody added such checks. Also .github stuff is kinda not the project itself but just the CI scripts that should be simple, but we're introducing code there just now (again not saying its a bad idea but obviously it was not there before)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically generate parts of CI matrix
4 participants