Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add solara #23413

Merged
merged 20 commits into from
Jul 21, 2023
Merged

Add solara #23413

merged 20 commits into from
Jul 21, 2023

Conversation

dhirschfeld
Copy link
Member

@dhirschfeld dhirschfeld commented Jul 20, 2023

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found some lint.

Here's what I've got...

For recipes/solara:

  • The home item is expected in the about section.
  • The summary item is expected in the about section.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found it was in an excellent condition.

@maartenbreddels
Copy link
Contributor

Cool, but see #22935 :)

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found some lint.

Here's what I've got...

For recipes/solara:

  • The "outputs" section was expected to be a list, but got a builtins.NoneType.
  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'outputs', 'about', 'extra'].
  • The "outputs" section was expected to be a list, but got a builtins.NoneType.
  • The "outputs" section was expected to be a list, but got a builtins.NoneType.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found it was in an excellent condition.

@dhirschfeld dhirschfeld marked this pull request as draft July 21, 2023 05:39
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found some lint.

Here's what I've got...

For recipes/solara:

  • The outputs section contained an unexpected subsection name. source is not a valid subsection name.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found it was in an excellent condition.

@maartenbreddels
Copy link
Contributor

Multi output can only have 1 source? So we cannot have 1 recipe that depends on 2 pypi tarballs and produces 2 outputs?

@dhirschfeld
Copy link
Member Author

Multi output can only have 1 source? So we cannot have 1 recipe that depends on 2 pypi tarballs and produces 2 outputs?

You can have multiple sources - you just specify the folder to extract to (then cd to it before building).

I'll get solara building correctly before adding solara-assets as a 2nd output.

@dhirschfeld
Copy link
Member Author

Not sure why pip is installing deps - I thought --no-deps got automatically added by conda-forge 🤔

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found some lint.

Here's what I've got...

For recipes/solara:

  • The home item is expected in the about section.
  • The license item is expected in the about section.
  • The summary item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found some lint.

Here's what I've got...

For recipes/solara:

  • The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'outputs', 'about', 'extra'].

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found it was in an excellent condition.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found some lint.

Here's what I've got...

For recipes/solara:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/solara) and found it was in an excellent condition.

@dhirschfeld
Copy link
Member Author

@maartenbreddels - would you like me to add you as a maintainer?

@maartenbreddels
Copy link
Contributor

Yes, please also add @mariobuikhuizen

@dhirschfeld
Copy link
Member Author

dhirschfeld commented Jul 21, 2023

I think we're hitting this issue - conda/conda-build#4415

In any case, the build hash is different between the packages so, IIUC we can't use pin_subpackage

The reported errors are:
- Encountered problems while solving:
-   - package solara-1.19.0-pyhd8ed1ab_0 has constraint solara-assets 1.19.0 py_0 conflicting with solara-assets-1.19.0-pyh1a96a4e_0

@maartenbreddels
Copy link
Contributor

🤦 😂

@dhirschfeld dhirschfeld marked this pull request as ready for review July 21, 2023 12:39
@dhirschfeld
Copy link
Member Author

dhirschfeld commented Jul 21, 2023

@conda-forge/help-python I think this is ready to merge!

@dhirschfeld
Copy link
Member Author

@conda-forge/help-python I think this is ready to merge!

...assuming you're happy with it @maartenbreddels?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants