-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graph: display the oci graph #49
Conversation
graph/index.html
Outdated
@@ -25,6 +25,7 @@ | |||
var pageInfra = ""; | |||
var pageStream = ""; | |||
var pageArch = ""; | |||
var pageOci = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused var?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, the whole navbar is broken. I tried to add a toggle for OCI but could not get it to work, that's a left over. Removed now
Cincinnati now serves a separate graph for OCI images, since coreos/fedora-coreos-cincinnati#99 Allow displaying the oci graph by passing `oci=true` as a query parameter. See coreos/fedora-coreos-tracker#1823
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image link works as expected,
updatesUrl makes sense.
/lgtm
Hmm, ideally we'd also have a dropdown to select between OCI/OSTree graphs? I guess the OSTree one will become less and less used after we've migrated, but for historical/debugging, it'd still be useful to make it easy to visualize. |
yes, i tried ! But the whole dropdown bar is broken, none works, at least for me, and I wasn't able to fix it :) |
Cincinnati now serves a separate graph for OCI images, since coreos/fedora-coreos-cincinnati#99
Allow displaying the oci graph by passing
oci=true
as a query parameter.See coreos/fedora-coreos-tracker#1823
Also, fix the header logo