Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph: display the oci graph #49

Merged
merged 1 commit into from
Jan 15, 2025
Merged

graph: display the oci graph #49

merged 1 commit into from
Jan 15, 2025

Conversation

jbtrystram
Copy link
Contributor

Cincinnati now serves a separate graph for OCI images, since coreos/fedora-coreos-cincinnati#99

Allow displaying the oci graph by passing oci=true as a query parameter.
See coreos/fedora-coreos-tracker#1823

Also, fix the header logo

graph/index.html Outdated Show resolved Hide resolved
graph/index.html Outdated
@@ -25,6 +25,7 @@
var pageInfra = "";
var pageStream = "";
var pageArch = "";
var pageOci = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused var?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, the whole navbar is broken. I tried to add a toggle for OCI but could not get it to work, that's a left over. Removed now

Cincinnati now serves a separate graph for OCI images, since
coreos/fedora-coreos-cincinnati#99

Allow displaying the oci graph by passing `oci=true` as a query
parameter.
See coreos/fedora-coreos-tracker#1823
Copy link
Member

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image link works as expected,

updatesUrl makes sense.

/lgtm

@jbtrystram jbtrystram merged commit 62a6121 into coreos:main Jan 15, 2025
1 check passed
@jlebon
Copy link
Member

jlebon commented Jan 27, 2025

Hmm, ideally we'd also have a dropdown to select between OCI/OSTree graphs? I guess the OSTree one will become less and less used after we've migrated, but for historical/debugging, it'd still be useful to make it easy to visualize.

@jbtrystram
Copy link
Contributor Author

Hmm, ideally we'd also have a dropdown to select between OCI/OSTree graphs? I guess the OSTree one will become less and less used after we've migrated, but for historical/debugging, it'd still be useful to make it easy to visualize.

yes, i tried ! But the whole dropdown bar is broken, none works, at least for me, and I wasn't able to fix it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants