-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add function #223
add function #223
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exempt_users: | ||
- bot1 | ||
- bot2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example values must be commented out
@@ -110,6 +110,10 @@ def update_branch_protection(repo): | |||
config = load_branch_protection_config() | |||
exempt_repositories = config["EXEMPT_REPOSITORIES"] | |||
required_status_check_map = config["REQUIRED_STATUS_CHECK_MAP"] | |||
|
|||
# Fetch exempt users (bots) for the repo if specified | |||
exempt_users = config.get("EXEMPT_USERS", {}).get(repo.name, []) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the YAML key is lowercase (exempt_users
)
@@ -12,7 +12,10 @@ EXEMPT_REPOSITORIES: | |||
# exempted for bot pushes to default branch | |||
- quantifying | |||
# special purpose repo | |||
- sre-wiki-js | |||
- sre-wiki-js : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there shouldn't be a space between key and colon
@Noela-Murugi also, please update the title to be more descriptive |
@@ -12,7 +12,10 @@ EXEMPT_REPOSITORIES: | |||
# exempted for bot pushes to default branch | |||
- quantifying | |||
# special purpose repo | |||
- sre-wiki-js | |||
- sre-wiki-js : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the repository is exempt (under EXEMPT_REPOSITORIES
), then exempt_users
will never be used
⛔️ status: discarded
|
Fixes
Description
Technical details
Tests
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin