Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Exclusion of Exempt Users #224

Merged

Conversation

Silvia-Wachira
Copy link

Fixes

Description

This PR is meant to exempt some specific users like bots from branch protection rules so that they can bypass restrictions like PR request reviews but still maintain protection for other users. This ensures that trusted users can perform their functions without manual intervention.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Silvia-Wachira Silvia-Wachira requested a review from a team as a code owner October 7, 2024 12:45
@Silvia-Wachira Silvia-Wachira requested review from TimidRobot and Shafiya-Heena and removed request for a team October 7, 2024 12:45
@TimidRobot TimidRobot added the 🚧 status: blocked Blocked & therefore, not ready for work label Oct 7, 2024
@TimidRobot TimidRobot self-assigned this Oct 7, 2024
@TimidRobot
Copy link
Member

TimidRobot commented Oct 7, 2024

🚧 status: blocked Blocked & therefore, not ready for work by earlier and nearly identical submission:

@Silvia-Wachira it looks like you copied code. If so, it would be much better to collaborate with the original author (ex. by commenting on their PR and/or submitting a PR to their branch)

@Silvia-Wachira
Copy link
Author

🚧 status: blocked Blocked & therefore, not ready for work by earlier and nearly identical submission:

@Silvia-Wachira it looks like you copied code. If so, it would be much better to collaborate with the original author (ex. by commenting on their PR and/or submitting a PR to their branch)

@TimidRobot I was trying to test the functionality with a friend but she submitted a PR accidentally. The code is mine though so I will request them to delete their PR.

@TimidRobot TimidRobot removed the 🚧 status: blocked Blocked & therefore, not ready for work label Oct 8, 2024
@TimidRobot TimidRobot mentioned this pull request Oct 8, 2024
7 tasks
@Silvia-Wachira
Copy link
Author

@TimidRobot Hi. I made the necessary changes,could you please review this for me?

Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! thank you!!

@TimidRobot TimidRobot merged commit 532203e into creativecommons:main Oct 15, 2024
@Silvia-Wachira
Copy link
Author

My first merge! I'm so excited! Thank you @TimidRobot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature] Allow excluded users (ex. bots) in branch protection implementation
2 participants