[dagster-azure] fix integration tests #27026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangenfeld
reviewed
Jan 10, 2025
| upload_interval: 30 | ||
| show_url_only: true |
There was a problem hiding this comment.
can you add a little more context as to why we are setting this to true for all of them?
There was a problem hiding this comment.
sure - all of these currently use the "logs captured context" to retrieve the url. Without it, we need to derive the URL using a separate mechanism.
I plan on adding some tests for that path down the line.
There was a problem hiding this comment.
you can also just take a look at https://app.graphite.dev/github/pr/dagster-io/dagster/27041/dagster-azure-default-behavior-testing if you feel more comfortable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fixes integration tests after most recent PR which disabled default log capture
How I Tested These Changes
Existing tests now work