Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-azure] fix integration tests #27026

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[dagster-azure] fix integration tests #27026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...uites/dagster-azure-live-tests/integration_tests/dagster-yamls/access-key-credential.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ compute_logs:
prefix:
env: TEST_AZURE_LOG_PREFIX
local_dir: "/tmp/cool"
upload_interval: 30
upload_interval: 30
show_url_only: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a little more context as to why we are setting this to true for all of them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure - all of these currently use the "logs captured context" to retrieve the url. Without it, we need to derive the URL using a separate mechanism.

I plan on adding some tests for that path down the line.

Copy link
Contributor Author

@dpeng817 dpeng817 Jan 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can also just take a look at https://app.graphite.dev/github/pr/dagster-io/dagster/27041/dagster-azure-default-behavior-testing if you feel more comfortable

3 changes: 2 additions & 1 deletion ...t_suites/dagster-azure-live-tests/integration_tests/dagster-yamls/default-credential.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ compute_logs:
prefix:
env: TEST_AZURE_LOG_PREFIX
local_dir: "/tmp/cool"
upload_interval: 30
upload_interval: 30
show_url_only: true
3 changes: 2 additions & 1 deletion ...st_suites/dagster-azure-live-tests/integration_tests/dagster-yamls/secret-credential.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ compute_logs:
prefix:
env: TEST_AZURE_LOG_PREFIX
local_dir: "/tmp/cool"
upload_interval: 30
upload_interval: 30
show_url_only: true