Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying path for storing cookies #547

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow specifying path for storing cookies #547

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d35bde7
Allow specifying path for storing cookies
kasatani Jul 20, 2017
a5f1336
Create cookiejar with no args when path is not specified
kasatani Oct 6, 2017
671cb0d
Add testcase for loading and saving cookies
kasatani Oct 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,8 @@ ghostdriver.Session = function(desiredCapabilities) {
},
_windows = {}, //< NOTE: windows are "webpage" in Phantom-dialect
_currentWindowHandle = null,
_cookieJar = require('cookiejar').create(),
_cookieJar,
_cookiePath = null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default should be an empty string to be consistent with the phantomjs source. though i'd prefer to be conservative and pass no arguments when this option is not used.

_id = require("./third_party/uuid.js").v1(),
_inputs = ghostdriver.Inputs(),
_capsPageSettingsPref = "phantomjs.page.settings.",
Expand All @@ -139,6 +140,12 @@ ghostdriver.Session = function(desiredCapabilities) {
_log = ghostdriver.logger.create("Session [" + _id + "]"),
k, settingKey, headerKey, proxySettings;

if (desiredCapabilities['phantomjs.cookies.path']) {
_cookiePath = desiredCapabilities['phantomjs.cookies.path'];
_negotiatedCapabilities['phantomjs.cookies.path'] = _cookiePath;
}
_cookieJar = require('cookiejar').create(_cookiePath);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default case should be the same. require('cookiejar').create()


var
/**
* Parses proxy JSON object and return proxy settings for phantom
Expand Down