suggested fix for flex behavior of the inputs #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpoetzsch
changed the title
|
Wait ... so how do I get the flex working? I'm looking at the demo but I don't see it. |
|
Well, with the currently released md-pickers you don't. This needs the fixed version that this PR suggests. To check it out in your code what you can do is to apply the changes of this PR to the appropriate files in |
|
I am using the single JS file. Do you know where I would make those edits in |
|
you make the changes in the file that you actually load. Usually this is the dist file ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggested fix for issue #25.
The new behavior is reflected in the default options section of the demo.
Although I generally think this change is for the better, it's worth noting that it might break backwards compatibility in design for some people. Probably it is a good idea to bump the version number to 2.0.0 with this change (following semver). What do you think?
@mbrahimi617 please check if this fixes the behavior for you.