This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 101
Fix wrapObject typeFooDerivedFromBar then unwrapObject typeBar will cause error on iOS #229
Open
flyskywhy
wants to merge
28
commits into
facebookresearch:main
Choose a base branch
from
flyskywhy:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ause error on iOS, e.g. image.getWidth() will be -1 Summary: the type in JSContext.wrapObject of photoOutput in CameraView.swift is Image the type in JSContextUtils.unwrapObject of getWidth in ImageModule.swift is IImage tested in `RN0.64.3` with `Xcode14.0.1(14A400)` on `macOS Monterey 12.6.5 (21G531)`
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
…UIManager.dispatchViewManagerCommand 500ms with CameraViewManager.java
…t-native-playtorch to fix java.lang.UnsatisfiedLinkError: couldn't find DSO to load: libtorchlive.so
…format on Android
…odules/react-native/android' to contain exactly one file, however, it contains no files`
…d in modules jetified-fbjni-0.3.0-runtime (com.facebook.fbjni:fbjni:0.3.0) and jetified-fbjni-java-only-0.2 (com.facebook.fbjni:fbjni-java-only:0.2.2)`, ref to facebook/react-native#34328 (comment)
…variables are used in this project, but they are set to NOTFOUND. FBJNI_LIB`, ref to mrousavy/react-native-vision-camera@b82d0e
…/jni/arm64-v8a/libpytorch_jni_lite.so', missing and no known rule to make it`
…ed: cannot locate symbol "__emutls_get_address" referenced by "/data/app/~~Bu6UWdRieDpDrpvvyvNNVQ==/com.foo.bar-w8nusksLnLfSCCsWG3cEkg==/lib/arm64/libfolly_runtime.so](facebook/react-native#43126)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrapObject typeFooDerivedFromBar then unwrapObject typeBar will cause error on iOS, e.g.
image.getWidth()
will be -1, orError: react_native_pytorch_core.MediaToBlob.MediaToBlobError.unknownUnwrappedObject
Summary
the type in
JSContext.wrapObject
ofphotoOutput
inCameraView.swift
isImage
the type in
JSContextUtils.unwrapObject
ofgetWidth
inImageModule.swift
isIImage
Changelog
IImage
toImage
aroundJSContext.wrapObject
andJSContextUtils.unwrapObject
Test Plan
tested in
RN0.64.3
withXcode14.0.1(14A400)
onmacOS Monterey 12.6.5 (21G531)
,iOS 14.4.2
on iPhone7