Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/5937 Upgrade python v3.11 #6097

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tmpayton
Copy link
Contributor

@tmpayton tmpayton commented Jan 8, 2025

Summary (required)

This PR upgrades python to version 3.11 which requires an invoke upgrade.

Required reviewers 1 - 2 developers

Impacted areas of the application

General components of the application that this PR will affect:

  • task.py
  • deploy

Related PRs

Related PRs against other branches:

branch PR
cms fecgov/fec-cms#6627

How to test

  • install python 3.11: pyenv install 3.11
  • create new virtual environment: pyenv virtualenv 3.11 <new env>
  • activate virtual environment: pyenv activate <new env>
  • install dependencies: pip install -r requirements.txt and pip install -r requirements-dev.txt
    • Note: I had to upgrade pip, setuptools, packaging, and wheel locally
  • pytest
  • test invoke commands:
    • invoke add-hooks
    • invoke create-sample-db
  • test api: flask run
  • test deploy using dev test branch: https://app.circleci.com/pipelines/github/fecgov/openFEC/3225/workflows/3d946d02-4982-46ef-a78a-90e1d8ac2bd9

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.46%. Comparing base (f303b47) to head (ab18e8c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6097      +/-   ##
===========================================
- Coverage    88.48%   88.46%   -0.03%     
===========================================
  Files           82       82              
  Lines         9139     9139              
===========================================
- Hits          8087     8085       -2     
- Misses        1052     1054       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmpayton tmpayton changed the title [WIP] Feature/5937 Upgrade python v3.11 Feature/5937 Upgrade python v3.11 Jan 8, 2025
@tmpayton tmpayton requested review from fec-jli, cnlucas and pkfec January 8, 2025 20:27
Copy link
Contributor

@fec-jli fec-jli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. good job. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Upgrade python 3.11
2 participants