Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Subordinate IDs main page #651

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

carma12
Copy link
Collaborator

@carma12 carma12 commented Feb 25, 2025

The 'Subordinate IDs' page should show the data related to a given user that has a subordinate ID and its range.

The current solution provides functionality for some buttons ('Refresh') and pagination. The rest of the functionality will be provided in another PR.

The main page is being rendered using a reusable component MainPage that allows listing elements with some basic configuration (showing links or checkboxes, and selection functionality).

@carma12 carma12 added the needs-review This PR is waiting on a review label Feb 25, 2025
@carma12
Copy link
Collaborator Author

carma12 commented Feb 25, 2025

Checking why the CI tests are not being triggered when created the PR...

@carma12 carma12 added WIP Work in Progress (do not merge) and removed needs-review This PR is waiting on a review labels Feb 25, 2025
@carma12 carma12 force-pushed the subordinate-ids-main-page branch 2 times, most recently from 72b2b00 to 03ee670 Compare February 26, 2025 07:44
@carma12 carma12 added needs-review This PR is waiting on a review and removed WIP Work in Progress (do not merge) labels Feb 26, 2025
@carma12
Copy link
Collaborator Author

carma12 commented Feb 26, 2025

Checking why the CI tests are not being triggered when created the PR...

It seems a GitHub hiccup. It works now.

Copy link
Contributor

@duzda duzda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that LGTM

The 'Subordinate IDs' page should show the
data related to a given user that has a
subordinate ID and its range.

The current solution provides functionality
for some buttons ('Refresh') and pagination.

The main page is being rendered using a
reusable component `MainPage` that allows
listing elements with some basic configuration
(showing links or checkboxes, and selection
functionality).

Signed-off-by: Carla Martinez <[email protected]>
@carma12 carma12 force-pushed the subordinate-ids-main-page branch from 03ee670 to b87bf16 Compare February 27, 2025 12:23
@carma12 carma12 requested a review from duzda February 27, 2025 12:42
@carma12
Copy link
Collaborator Author

carma12 commented Feb 27, 2025

Checking the tests again...

@carma12
Copy link
Collaborator Author

carma12 commented Feb 27, 2025

Checking the tests again...

Seem ok now. Merging.

@carma12 carma12 merged commit eb9f80f into freeipa:main Feb 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review This PR is waiting on a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants