Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clang-format rules #1629

Merged
merged 11 commits into from
Jan 28, 2025
Merged

Update clang-format rules #1629

merged 11 commits into from
Jan 28, 2025

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented Jan 28, 2025

Fixes #1624

clang-format -i include/**/*.hpp src/**/*.cpp test/**/*.cpp is now a no-op with clang-format 19.1.7.

The big change is InsertBraces: true, so now we consistently use { braces }!

(A less-big change is to standardize on // line comments, although clang-format can't enforce that.)

I decided against SeparateDefinitionBlocks: Always because we often group method declarations together in header files, and it also line-separates those.

@Rangi42 Rangi42 added rgbasm This affects RGBASM rgblink This affects RGBLINK rgbfix This affects RGBFIX rgbgfx This affects RGBGFX refactoring This PR is intended to clean up code more than change functionality labels Jan 28, 2025
@Rangi42 Rangi42 added this to the 0.9.1 milestone Jan 28, 2025
@Rangi42 Rangi42 changed the title Clang format Update clang-format rules Jan 28, 2025
@Rangi42 Rangi42 merged commit 79401cc into gbdev:master Jan 28, 2025
26 checks passed
@Rangi42 Rangi42 deleted the clang-format branch January 28, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This PR is intended to clean up code more than change functionality rgbasm This affects RGBASM rgbfix This affects RGBFIX rgbgfx This affects RGBGFX rgblink This affects RGBLINK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update clang-format rules
1 participant