Support getting hit vertex positions. #7141
Open
+1,462
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # naga/src/back/hlsl/writer.rs # naga/src/valid/handles.rs # naga/src/valid/mod.rs # wgpu-core/src/device/ray_tracing.rs # wgpu-core/src/ray_tracing.rs # wgpu-hal/src/dx12/conv.rs # wgpu-hal/src/dx12/device.rs # wgpu-hal/src/metal/device.rs # wgpu-hal/src/vulkan/adapter.rs # wgpu-types/src/lib.rs
…cing-get-vertex # Conflicts: # naga/src/back/spv/ray.rs # naga/src/compact/types.rs # naga/src/proc/mod.rs # wgpu-hal/examples/ray-traced-triangle/main.rs # wgpu-hal/src/dx12/device.rs
…cing-get-vertex # Conflicts: # wgpu-types/src/lib.rs
…cing-get-vertex # Conflicts: # etc/specs/ray_tracing.md # naga/src/back/spv/instructions.rs # wgpu-core/src/device/ray_tracing.rs # wgpu-core/src/ray_tracing.rs # wgpu-types/src/lib.rs
kentslaney
reviewed
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #6763
Description
Supports getting the vertices out of the ray query with a new function. In naga's extended WGSL language this requires
acceleration_structure<vertex_return>, even though other shader languages don't require this, due to validation requirements. If we go the same route as other shader languages, the validation requirements (as far as I can tell) areget*HitVertexPositionstags ray query object. Thisray_querythen needs to find all uses of itself - iterating through all blocks it's valid in and finding anyrayQueryInitializeand tagging allacceleration_structures. This alternate design could also lead to more user confusion. The implemented design instead disallowsrayQueryInitializeinitializing aray_query<vertex_return>with a untaged acceleration structure and disallowing callingget*HitVertexPositionswith an untaggedray_query.Testing
Adds an example which demonstrates the use of the newly added function. Adds two tests for invalid uses of this flag.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.