-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better grasping for xArm7 #131
Better grasping for xArm7 #131
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @s1lent4gnt! Can you add a little Changelog section in the README (see the unitree_g1
for an example) to describe succinctly the changes you made in this PR?
Hey @kevinzakka, I’ve added references to both the Issue and this PR in the Changelog section. Does this look okay, or would you prefer not to include them? |
0d5b4e2
to
b5a72f9
Compare
@yuvaltassa @saran-t ready to merge! |
Great! Probably after the holidays 😄 |
What this does
This PR addresses the Graspin issue discussed in #83. The resolution includes the following changes:
xarm7.xml
,xarm7_nohand.xml
, andhand.xml
files by addingarmature=0.1
to the xArm7 joints.How it was tested
The changes were verified using the Mink Python library, with results documented in #83.