-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Emit table select event only if selection changes #2196 #2201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marek-mihok. Needs some work.
Your demo still fires select events on search/filter action. It should not. The select
event should solely be fired only when user selects a row or clicks select/deselect all.
b241b11
to
64767aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @marek-mihok!
64767aa
to
4744231
Compare
The PR fulfills these requirements: (check all the apply)
main
branch.feat: Add a button #xxx
, where "xxx" is the issue number).Closes #xxx
, where "xxx" is the issue number.ui
folder, unit tests (make test
) still pass.Fixed by updating FluentUI to slightly newer version supporting custom
onItemsChanged
event callback fired after Fluent internalitems
are updated but beforeonSelectionChanged
. This way we can preventselect
event from being emitted anytimeitems
are updated. Now the only way of firing the event is to select/deselect row or select/deselect all rows.Both unit and visual regression tests pass after FluentUI update.
Screen.Recording.2023-11-30.at.17.26.19.mov
Closes #2196