-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sint32
& Sint64
types & libfuncs
#383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
20.749 ± 0.087 | 20.609 | 20.896 | 43.68 ± 0.65 |
cairo-native (JIT MLIR ORC Engine) |
1.527 ± 0.014 | 1.511 | 1.548 | 3.21 ± 0.05 |
cairo-native (AOT Native binary) |
0.661 ± 0.002 | 0.659 | 0.664 | 1.39 ± 0.02 |
cairo-native (AOT Native binary with host CPU features, march=native) |
0.475 ± 0.007 | 0.471 | 0.491 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
20.265 ± 0.110 | 20.124 | 20.460 | 649.75 ± 8.82 |
cairo-native (JIT MLIR ORC Engine) |
1.109 ± 0.005 | 1.098 | 1.116 | 35.55 ± 0.47 |
cairo-native (AOT Native binary) |
0.031 ± 0.000 | 0.031 | 0.032 | 1.00 |
cairo-native (AOT Native binary with host CPU features, march=native) |
0.031 ± 0.000 | 0.031 | 0.032 | 1.00 ± 0.01 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.912 ± 0.035 | 1.870 | 1.993 | 27.36 ± 0.50 |
cairo-native (JIT MLIR ORC Engine) |
1.415 ± 0.017 | 1.395 | 1.451 | 20.25 ± 0.25 |
cairo-native (AOT Native binary) |
0.109 ± 0.000 | 0.109 | 0.110 | 1.56 ± 0.01 |
cairo-native (AOT Native binary with host CPU features, march=native) |
0.070 ± 0.000 | 0.070 | 0.071 | 1.00 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #383 +/- ##
==========================================
+ Coverage 75.89% 77.24% +1.35%
==========================================
Files 100 102 +2
Lines 23897 25366 +1469
==========================================
+ Hits 18136 19595 +1459
- Misses 5761 5771 +10 ☔ View full report in Codecov by Sentry. |
edg-l
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #382
Libfunc implementations adapted from previous sint types
Also merged some tests together to reduce the amount of test files per type
Fixes iX_const_min unit test using 0 instead of min value for previous sint types