Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sint32 & Sint64 types & libfuncs #383

Merged
merged 33 commits into from
Dec 15, 2023
Merged

Add Sint32 & Sint64 types & libfuncs #383

merged 33 commits into from
Dec 15, 2023

Conversation

fmoletta
Copy link
Collaborator

@fmoletta fmoletta commented Dec 13, 2023

Based on #382
Libfunc implementations adapted from previous sint types
Also merged some tests together to reduce the amount of test files per type
Fixes iX_const_min unit test using 0 instead of min value for previous sint types

@fmoletta fmoletta mentioned this pull request Dec 13, 2023
5 tasks
Copy link

github-actions bot commented Dec 13, 2023

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.749 ± 0.087 20.609 20.896 43.68 ± 0.65
cairo-native (JIT MLIR ORC Engine) 1.527 ± 0.014 1.511 1.548 3.21 ± 0.05
cairo-native (AOT Native binary) 0.661 ± 0.002 0.659 0.664 1.39 ± 0.02
cairo-native (AOT Native binary with host CPU features, march=native) 0.475 ± 0.007 0.471 0.491 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.265 ± 0.110 20.124 20.460 649.75 ± 8.82
cairo-native (JIT MLIR ORC Engine) 1.109 ± 0.005 1.098 1.116 35.55 ± 0.47
cairo-native (AOT Native binary) 0.031 ± 0.000 0.031 0.032 1.00
cairo-native (AOT Native binary with host CPU features, march=native) 0.031 ± 0.000 0.031 0.032 1.00 ± 0.01

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 1.912 ± 0.035 1.870 1.993 27.36 ± 0.50
cairo-native (JIT MLIR ORC Engine) 1.415 ± 0.017 1.395 1.451 20.25 ± 0.25
cairo-native (AOT Native binary) 0.109 ± 0.000 0.109 0.110 1.56 ± 0.01
cairo-native (AOT Native binary with host CPU features, march=native) 0.070 ± 0.000 0.070 0.071 1.00

@fmoletta fmoletta changed the base branch from main to sint16 December 14, 2023 14:10
@fmoletta fmoletta marked this pull request as ready for review December 14, 2023 14:15
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (52f8e19) 75.89% compared to head (72f9dff) 77.24%.

Files Patch % Lines
src/jit_runner.rs 57.14% 9 Missing ⚠️
src/libfuncs/sint32.rs 99.01% 7 Missing ⚠️
src/libfuncs/sint64.rs 99.01% 7 Missing ⚠️
src/values.rs 75.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #383      +/-   ##
==========================================
+ Coverage   75.89%   77.24%   +1.35%     
==========================================
  Files         100      102       +2     
  Lines       23897    25366    +1469     
==========================================
+ Hits        18136    19595    +1459     
- Misses       5761     5771      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from sint16 to main December 14, 2023 15:44
@edg-l edg-l merged commit 3c6d762 into main Dec 15, 2023
8 checks passed
@edg-l edg-l deleted the sint3264 branch December 15, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants