Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Bedrock Callback #324

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

wolfgangcolsman
Copy link

This pull request makes the following changes:

  • add llm_output to ChatResult in ChatBedrockConverse
  • add BedrockTokenUsageCallbackHandler
  • add get_bedrock_callback()

The implementation of cache create and cache read is not tested yet as prompt caching is not available to all AWS customers at this time point.

For more information on prompt caching, see
https://docs.aws.amazon.com/bedrock/latest/userguide/prompt-caching.html https://docs.aws.amazon.com/bedrock/latest/userguide/conversation-inference-call.html

@3coins 3coins added the enhancement New feature or request label Jan 16, 2025
Copy link
Collaborator

@michaelnchin michaelnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wolfgangcolsman, thank you for your submission.

For now, we're looking to avoid migrating the Bedrock token counting callback class to this package, due to maintenance costs associated with the hard-coded model names and prices.

However, the changes do look reasonable to me. I would suggest opening a separate pull request in the main LangChain repository to modify the original Bedrock callback class for langchain-community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants