Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: re-add k8s install e2e #3530

Merged
merged 3 commits into from
Jan 14, 2025
Merged

fix: re-add k8s install e2e #3530

merged 3 commits into from
Jan 14, 2025

Conversation

blva
Copy link
Collaborator

@blva blva commented Jan 10, 2025 •
edited
Loading

Proposed changes

Adds k8s install test back

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva requested a review from a team as a code owner January 10, 2025 11:24
@apix-bot APIx Bot
Copy link
Contributor

apix-bot bot commented Jan 10, 2025

Coverage Report 📈

Branch Commit Coverage
master 2f744f6 38.8%
re-add-install-e2e 906375c 38.8%
Difference 0%

andreaangiolillo
andreaangiolillo approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@andreaangiolillo andreaangiolillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cveticm
cveticm approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@cveticm cveticm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a reminder that we expect 2 test failures as outlined in this bug ticket!

@blva blva merged commit e021ea5 into master Jan 14, 2025
20 of 22 checks passed
@blva blva deleted the re-add-install-e2e branch January 14, 2025 11:22
@s-urbaniak s-urbaniak mentioned this pull request Jan 20, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cveticm cveticm cveticm approved these changes

@andreaangiolillo andreaangiolillo andreaangiolillo approved these changes

Assignees
No one assigned
Labels
atlascli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blva @andreaangiolillo @cveticm