Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Featured collections are displayed in a column #240

Open
1 task
jillpe opened this issue Feb 14, 2025 · 3 comments
Open
1 task

Featured collections are displayed in a column #240

jillpe opened this issue Feb 14, 2025 · 3 comments
Assignees
@sjproctor
Labels
cutover bug

Comments

@jillpe
Copy link

jillpe commented Feb 14, 2025 •
edited
Loading

Summary

Featured Collections are being displayed in a column instead of a row on the cultural and neutral themes

Acceptance Criteria

  • Featured collections are displayed in a row on cultural and neutral themes
@jillpe jillpe converted this from a draft issue Feb 14, 2025
@jillpe
Copy link
Author

jillpe commented Feb 17, 2025

Did the assets compile correctly?

@sjproctor
Copy link
Contributor

sjproctor commented Feb 17, 2025 •
edited
Loading

Replicating the Problem

  • On production
  • User must be logged out
  • Must be two or more featured collections

Neutral Theme

Photo: Logged out home page

Image

Cultural Theme

From #142: Featured Collections span the entire container like HykuCommons (only when logged in)

Photo: Logged out home page

Image

This is also not working in Hyku Image

@sjproctor sjproctor self-assigned this Feb 18, 2025
@sjproctor sjproctor moved this from Ready for Development to In Development in PalsKnapsack Feb 18, 2025
sjproctor added a commit to samvera/hyku that referenced this issue Feb 18, 2025
@sjproctor
🐛 Neutral Theme logged out home page styling
b81dc84 
This commit:
- replaces the table structure with Bootstrap grid layout for logged out
view on the neutral theme homepage
- uses container-fluid and row classes to ensure collections sit side
by side on the homepage and ensures it is responsive
- maintain existing admin view with sortable interface
- ensure compatibility with neutral theme collection display

Ref:
- notch8/palni_palci_knapsack#240
@sjproctor sjproctor mentioned this issue Feb 18, 2025
Merged
@sjproctor sjproctor moved this from In Development to Code Review in PalsKnapsack Feb 18, 2025
ShanaLMoore added a commit that referenced this issue Feb 19, 2025
@ShanaLMoore
Update hyrax-webapp
12cc515 
pulls in the following issues from hyku:

- #239
- notch8/palni-palci#1019
- #194
- #240
@ShanaLMoore ShanaLMoore mentioned this issue Feb 19, 2025
Merged
@ShanaLMoore ShanaLMoore moved this from Code Review to SoftServ QA in PalsKnapsack Feb 19, 2025
@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Feb 19, 2025 •
edited
Loading

QA RESULTS: ✅ PASS

tested on STAGING

CULTURAL

  • Featured collections are displayed in a row on cultural and neutral themes
Image

NEUTRAL

  • Featured collections are displayed in a row on cultural and neutral themes
Image

cc @ndroark ready for your review

@ShanaLMoore ShanaLMoore moved this from SoftServ QA to Deploy to Staging in PalsKnapsack Feb 19, 2025
@ShanaLMoore ShanaLMoore moved this from Deploy to Staging to In Development in PalsKnapsack Feb 19, 2025
@ShanaLMoore ShanaLMoore moved this from In Development to SoftServ QA in PalsKnapsack Feb 19, 2025
@ShanaLMoore ShanaLMoore moved this from SoftServ QA to Client QA in PalsKnapsack Feb 19, 2025
@sjproctor sjproctor moved this from Client QA to In Development in PalsKnapsack Feb 19, 2025
sjproctor added a commit to samvera/hyku that referenced this issue Feb 20, 2025
@sjproctor
🐛 Rework home page featured collections layout
6843690 
This commit:
- added a conditional block for themes that display featured collections
in a grid layout on the home page for logged out users
- reverts a change that impacted the default theme's display of featured
collections on the home page for logged out users
- added specs to ensure correct page layout for the various themes

Ref:
- notch8/palni_palci_knapsack#240
@sjproctor sjproctor mentioned this issue Feb 20, 2025
Closed
sjproctor added a commit to samvera/hyku that referenced this issue Feb 20, 2025
@sjproctor
🐛 Cultural Repository Featured Collection Layout
e3de84c 
This commit:
- adds a new partial to the Cultural Repository theme to render the
featured collections in a grid format rather than a table
- add a spec for the Cultural Repository featured collection partial
- reverts previous changes to the default theme featured collection
layout partial and corresponding spec file

Ref:
- notch8/palni_palci_knapsack#240
sjproctor added a commit to samvera/hyku that referenced this issue Feb 20, 2025
@sjproctor
🐛 Institutional Theme Featured Collection Layout
a3a5ac1 
This commit:

- adds a new partial to the Institutional Repository theme to render the
featured collections in a grid format rather than a table
- adds a spec for the Institutional Repository featured collection partial

Ref:
- notch8/palni_palci_knapsack#240
sjproctor added a commit to samvera/hyku that referenced this issue Feb 20, 2025
@sjproctor
🐛 Neutral Theme Featured Collection Layout
1e3c7af 
This commit:
- adds a new partial to the Neutral Repository theme to render
the featured collections in a grid format rather than a table
- adds a spec for the Neutral Repository featured collection
partial

Ref:
- notch8/palni_palci_knapsack#240
@sjproctor sjproctor mentioned this issue Feb 20, 2025
Merged
@ShanaLMoore ShanaLMoore moved this from In Development to Deploy to Staging in PalsKnapsack Feb 20, 2025
@sjproctor sjproctor moved this from Deploy to Staging to In Development in PalsKnapsack Feb 20, 2025
@sjproctor sjproctor moved this from In Development to Client Verification in PalsKnapsack Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjproctor sjproctor

Labels
cutover bug
Projects
PalsKnapsack
Status: Client Verification
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ShanaLMoore @sjproctor @jillpe