1.2 LTS: Askar upgrade and fix profile unique names #3477
Merged
+21
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
|
Waiting for another askar library fix... |
Signed-off-by: jamshale <jamiehalebc@gmail.com>
|
dbluhm
approved these changes
Jan 30, 2025
swcurran
changed the title
|
Just confirming, this isn't out in a release yet, right? |
|
I'm not sure why this one didn't create a release. Not exactly sure what to do. I think create a tag and then run the publish workflow for it? The 0.12.lts was released properly. |
|
I didn't do anything for the 0.12.lts so I'll see if @swcurran knows what happened or I can try and get it released later today. |
|
My screw-up. I just didn’t create the release after the merge. The date is a bit messed up, but so be it. |
|
@dbluhm version 1.2.2 is available now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR to enable a patch release to upgrade Askar to 0.4.3 and fixes a problem with wallet names in a multitenant, single-wallet configuration.
Addresses the problem outlined in #3471 around profiles in the multi-tenant/single wallet configuration. The update to Askar address an intermittent hang on startup, and a dependency change that can result in a substantial performance improvement in some cases. See issues: openwallet-foundation/askar#350, openwallet-foundation/askar#351, openwallet-foundation/askar#354. This comment on one of the PRs describes the scenario where a substantial performance improvement was seen as a result of the change in Askar.