Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2 LTS: Askar upgrade and fix profile unique names #3477

Merged
merged 4 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions acapy_agent/askar/profile.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ def __init__(
profile_id: Optional[str] = None,
):
"""Create a new AskarProfile instance."""
super().__init__(context=context, name=opened.name, created=opened.created)
super().__init__(
context=context, name=profile_id or opened.name, created=opened.created
)
self.opened = opened
self.ledger_pool: Optional[IndyVdrLedgerPool] = None
self.profile_id = profile_id
Expand All @@ -52,7 +54,7 @@ def __init__(
@property
def name(self) -> str:
"""Accessor for the profile name."""
return self.opened.name
return self.profile_id or self.opened.name

@property
def store(self) -> Store:
Expand Down
6 changes: 4 additions & 2 deletions acapy_agent/askar/profile_anon.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,9 @@ def __init__(
profile_id: Optional[str] = None,
):
"""Create a new AskarProfile instance."""
super().__init__(context=context, name=opened.name, created=opened.created)
super().__init__(
context=context, name=profile_id or opened.name, created=opened.created
)
self.opened = opened
self.ledger_pool: Optional[IndyVdrLedgerPool] = None
self.profile_id = profile_id
Expand All @@ -54,7 +56,7 @@ def __init__(
@property
def name(self) -> str:
"""Accessor for the profile name."""
return self.opened.name
return self.profile_id or self.opened.name

@property
def store(self) -> Store:
Expand Down
50 changes: 11 additions & 39 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ uuid_utils = "^0.10.0"
# did libraries
did-peer-2 = "^0.1.2"
did-peer-4 = "^0.1.4"
did-webvh = "^0.2.1"
did-webvh = ">=0.3.0"

# Verifiable Credentials
indy-credx = "~1.1.1"
anoncreds = "0.2.0"

# askar
aries-askar = "~0.3.2"
aries-askar = ">=0.4.3"

# indy
indy-vdr = "~0.4.0"
Expand Down