Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accept login_challenge in SPA verification flows #4284

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

chore: add test

cde17c4
Select commit
Loading
Failed to load commit list.
Open

fix: accept login_challenge in SPA verification flows #4284

chore: add test
cde17c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2025 in 1s

78.59% (target 65.00%)

View this Pull Request on Codecov

78.59% (target 65.00%)

Details

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.59%. Comparing base (07cb83c) to head (cde17c4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
selfservice/flow/verification/handler.go 81.25% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4284      +/-   ##
==========================================
- Coverage   78.59%   78.59%   -0.01%     
==========================================
  Files         381      381              
  Lines       27370    27382      +12     
==========================================
+ Hits        21512    21521       +9     
- Misses       4236     4238       +2     
- Partials     1622     1623       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov