[In-Progress] Use generic SS58 prefix. #522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebma
approved these changes
Mar 4, 2025
runtime/foucoco/src/lib.rs
Outdated
| @@ -313,7 +313,7 @@ impl Contains<RuntimeCall> for BaseFilter { | |||
| RuntimeCall::Bounties(_) | | |||
| RuntimeCall::ChildBounties(_) | | |||
| RuntimeCall::ClientsInfo(_) | | |||
| RuntimeCall::Treasury(_) | | |||
| RuntimeCall::TreaSS58Prefixsury(_) | | |||
There was a problem hiding this comment.
This change doesn't seem intended to me 😅
There was a problem hiding this comment.
Yes, not ready yet. Just the first commit and PR to keep track of it :)
There was a problem hiding this comment.
Ah I'm sorry, I assumed it's ready already 😬
There was a problem hiding this comment.
It's fine! Actually, it may be. But we also need to perform changes on UI of portal and vortex, tests scripts, etc.
runtime/pendulum/src/lib.rs
Outdated
| @@ -408,7 +408,7 @@ impl frame_system::Config for Runtime { | |||
| type BlockWeights = RuntimeBlockWeights; | |||
| /// The maximum length of a block (in bytes). | |||
| type BlockLength = RuntimeBlockLength; | |||
| /// This is used as an identifier of the chain. 56 is the prefix for Pendulum | |||
| /// Previous chain identifier prefix for address format: 57. | |||
There was a problem hiding this comment.
It was 56 for Pendulum so we need to adjust the comment.
Suggested change
| /// Previous chain identifier prefix for address format: 57. | |
| /// Previous chain identifier prefix for address format: `56`. Now using the generic prefix `0`. |
runtime/foucoco/src/lib.rs
Outdated
| @@ -408,7 +408,7 @@ impl frame_system::Config for Runtime { | |||
| type BlockWeights = RuntimeBlockWeights; | |||
| /// The maximum length of a block (in bytes). | |||
| type BlockLength = RuntimeBlockLength; | |||
| /// This is used as an identifier of the chain. 57 is the prefix for Foucoco | |||
| /// Previous chain identifier prefix for address format: 57. | |||
There was a problem hiding this comment.
Suggested change
| /// Previous chain identifier prefix for address format: 57. | |
| /// Previous chain identifier prefix for address format: `57`. Now uses the generic prefix `0`. |
runtime/amplitude/src/lib.rs
Outdated
| @@ -406,7 +406,7 @@ impl frame_system::Config for Runtime { | |||
| type BlockWeights = RuntimeBlockWeights; | |||
| /// The maximum length of a block (in bytes). | |||
| type BlockLength = RuntimeBlockLength; | |||
| /// This is used as an identifier of the chain. 57 is the prefix for Amplitude | |||
| /// Previous chain identifier prefix for address format: 57. | |||
There was a problem hiding this comment.
Suggested change
| /// Previous chain identifier prefix for address format: 57. | |
| /// Previous chain identifier prefix for address format: `57`. Now uses the generic prefix `0`. |
gianfra-t
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Tasks/#456.