Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[In-Progress] Use generic SS58 prefix. #522

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[In-Progress] Use generic SS58 prefix. #522

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de80fd5
use generic ss58 prefix
gianfra-t Mar 4, 2025
19ab395
update comments, typo
gianfra-t Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion res/amplitude-spec-raw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"telemetryEndpoints": null,
"protocolId": "amplitude",
"properties": {
"ss58Format": 57,
"ss58Format": 0,
"tokenDecimals": 12,
"tokenSymbol": "AMPE"
},
Expand Down
2 changes: 1 addition & 1 deletion res/amplitude-spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"telemetryEndpoints": null,
"protocolId": "amplitude",
"properties": {
"ss58Format": 57,
"ss58Format": 0,
"tokenDecimals": 12,
"tokenSymbol": "AMPE"
},
Expand Down
2 changes: 1 addition & 1 deletion res/foucoco-paseo-spec-raw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"telemetryEndpoints": null,
"protocolId": "foucoco-p",
"properties": {
"ss58Format": 57,
"ss58Format": 0,
"tokenDecimals": 12,
"tokenSymbol": "AMPE"
},
Expand Down
2 changes: 1 addition & 1 deletion res/foucoco-spec-raw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"telemetryEndpoints": null,
"protocolId": "foucoco",
"properties": {
"ss58Format": 57,
"ss58Format": 0,
"tokenDecimals": 12,
"tokenSymbol": "AMPE"
},
Expand Down
2 changes: 1 addition & 1 deletion res/foucoco-spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"telemetryEndpoints": null,
"protocolId": "foucoco",
"properties": {
"ss58Format": 57,
"ss58Format": 0,
"tokenDecimals": 12,
"tokenSymbol": "AMPE"
},
Expand Down
2 changes: 1 addition & 1 deletion res/foucoco-standalone-spec-raw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"telemetryEndpoints": null,
"protocolId": "foucoco",
"properties": {
"ss58Format": 57,
"ss58Format": 0,
"tokenDecimals": 12,
"tokenSymbol": "AMPE"
},
Expand Down
2 changes: 1 addition & 1 deletion res/foucoco-standalone-spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"telemetryEndpoints": null,
"protocolId": "foucoco",
"properties": {
"ss58Format": 57,
"ss58Format": 0,
"tokenDecimals": 12,
"tokenSymbol": "AMPE"
},
Expand Down
2 changes: 1 addition & 1 deletion res/pendulum-spec-raw.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"telemetryEndpoints": null,
"protocolId": "pendulum",
"properties": {
"ss58Format": 56,
"ss58Format": 0,
"tokenDecimals": 12,
"tokenSymbol": "PEN"
},
Expand Down
2 changes: 1 addition & 1 deletion res/pendulum-spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"telemetryEndpoints": null,
"protocolId": "pendulum",
"properties": {
"ss58Format": 56,
"ss58Format": 0,
"tokenDecimals": 12,
"tokenSymbol": "PEN"
},
Expand Down
4 changes: 2 additions & 2 deletions runtime/amplitude/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ parameter_types! {
})
.avg_block_initialization(AVERAGE_ON_INITIALIZE_RATIO)
.build_or_panic();
pub const SS58Prefix: u16 = 57;
pub const SS58Prefix: u16 = 0;
}

pub struct BaseFilter;
Expand Down Expand Up @@ -406,7 +406,7 @@ impl frame_system::Config for Runtime {
type BlockWeights = RuntimeBlockWeights;
/// The maximum length of a block (in bytes).
type BlockLength = RuntimeBlockLength;
/// This is used as an identifier of the chain. 57 is the prefix for Amplitude
/// Previous chain identifier prefix for address format: 57.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Previous chain identifier prefix for address format: 57.
/// Previous chain identifier prefix for address format: `57`. Now uses the generic prefix `0`.

type SS58Prefix = SS58Prefix;
/// The action to take on a Runtime Upgrade
type OnSetCode = cumulus_pallet_parachain_system::ParachainSetCode<Self>;
Expand Down
6 changes: 3 additions & 3 deletions runtime/foucoco/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ parameter_types! {
})
.avg_block_initialization(AVERAGE_ON_INITIALIZE_RATIO)
.build_or_panic();
pub const SS58Prefix: u16 = 57;
pub const SS58Prefix: u16 = 0;
}

pub struct BaseFilter;
Expand All @@ -313,7 +313,7 @@ impl Contains<RuntimeCall> for BaseFilter {
RuntimeCall::Bounties(_) |
RuntimeCall::ChildBounties(_) |
RuntimeCall::ClientsInfo(_) |
RuntimeCall::Treasury(_) |
RuntimeCall::TreaSS58Prefixsury(_) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't seem intended to me 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, not ready yet. Just the first commit and PR to keep track of it :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I'm sorry, I assumed it's ready already 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine! Actually, it may be. But we also need to perform changes on UI of portal and vortex, tests scripts, etc.

RuntimeCall::Tokens(_) |
RuntimeCall::Currencies(_) |
RuntimeCall::ParachainStaking(_) |
Expand Down Expand Up @@ -408,7 +408,7 @@ impl frame_system::Config for Runtime {
type BlockWeights = RuntimeBlockWeights;
/// The maximum length of a block (in bytes).
type BlockLength = RuntimeBlockLength;
/// This is used as an identifier of the chain. 57 is the prefix for Foucoco
/// Previous chain identifier prefix for address format: 57.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Previous chain identifier prefix for address format: 57.
/// Previous chain identifier prefix for address format: `57`. Now uses the generic prefix `0`.

type SS58Prefix = SS58Prefix;
/// The action to take on a Runtime Upgrade
type OnSetCode = cumulus_pallet_parachain_system::ParachainSetCode<Self>;
Expand Down
4 changes: 2 additions & 2 deletions runtime/pendulum/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ parameter_types! {
})
.avg_block_initialization(AVERAGE_ON_INITIALIZE_RATIO)
.build_or_panic();
pub const SS58Prefix: u16 = 56;
pub const SS58Prefix: u16 = 0;
}

pub struct BaseFilter;
Expand Down Expand Up @@ -408,7 +408,7 @@ impl frame_system::Config for Runtime {
type BlockWeights = RuntimeBlockWeights;
/// The maximum length of a block (in bytes).
type BlockLength = RuntimeBlockLength;
/// This is used as an identifier of the chain. 56 is the prefix for Pendulum
/// Previous chain identifier prefix for address format: 57.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was 56 for Pendulum so we need to adjust the comment.

Suggested change
/// Previous chain identifier prefix for address format: 57.
/// Previous chain identifier prefix for address format: `56`. Now using the generic prefix `0`.

type SS58Prefix = SS58Prefix;
/// The action to take on a Runtime Upgrade
type OnSetCode = cumulus_pallet_parachain_system::ParachainSetCode<Self>;
Expand Down
Loading