Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code style #443

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

EmilMassey
Copy link

Currently CI checks fail due to code style issues being reported by the latest version of CS fixer. This PR fixes these issues and also changes configuration for trailing_comma_in_multiline fixer not to add comma after parameters, because it's not allowed in PHP 7.

@AlessandroMinoccheri
Copy link
Member

Hi @EmilMassey is it possible to fix pipelines?

@EmilMassey
Copy link
Author

EmilMassey commented Jan 11, 2025

Hi @AlessandroMinoccheri Does it make sense to run coding standard checks for PHP < 8.0? I added condition to skip this step in the pipelines, because the problem is that depending on PHP version, another CS Fixer version is installed and the configurations for both of them differ. Alternatively we could define different configuration options depending on the PHP version.

Also there's unrelated job failed for PHP 7.1 due to roave/security-advisories disallowing installation of vulnerable version of symfony/process: https://symfony.com/blog/cve-2024-51736-command-execution-hijack-on-windows-with-process-class. It seems update is not available for PHP 7.1, so maybe support for PHP 7.1 should be dropped altogether?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants